theforeman / obal

packaging wrapper using ansible
GNU General Public License v2.0
9 stars 13 forks source link

Allow running repoclosure based on a URL and dist #362

Closed ehelms closed 1 year ago

ehelms commented 1 year ago

Example:

obal-source repoclosure rubygem-pulp_file_client --check https://download.copr.fedorainfracloud.org/results/@theforeman/foreman-katello-nightly-staging-scratch-0b6bfd0a-f472-5d75-9280-3ae62f547728/rhel-8-x86_64/ --dist el8

This will allow us to stop downloading RPMs to create a local repository from and instead use the repositories created by the scratch repos from Copr to do repoclosure.

ehelms commented 1 year ago

@evgeni Take a look when you can

evgeni commented 1 year ago

So I am trying to wrap my head around "why do we need to introduce new args".

The URL makes sense -- it changes on every scratch build, and that is the one we wanna check. But the dist?

ehelms commented 1 year ago

So I am trying to wrap my head around "why do we need to introduce new args".

The URL makes sense -- it changes on every scratch build, and that is the one we wanna check. But the dist?

The dist is what tells our code which set of lookaside repositories to use -- https://github.com/theforeman/foreman-packaging/blob/rpm/develop/package_manifest.yaml#L155-L156

ehelms commented 1 year ago

This has been completely re-worked and re-designed using the module. Expected usage:

obal-source repoclosure rubygem-pulp_file_client --check https://download.copr.fedorainfracloud.org/results/@theforeman/foreman-katello-nightly-staging-scratch-0b6bfd0a-f472-5d75-9280-3ae62f547728/rhel-8-x86_64/ --dist el8