search

theforeman / obal

packaging wrapper using ansible
GNU General Public License v2.0
9 stars 13 forks source link

Rely on obsah to pull in Ansible #382

Closed ekohl closed 10 months ago

ekohl commented 10 months ago

obsah already pulls in either ansible or ansible-core, depending on the Python version. There's no need for obal itself to pull it in.

evgeni commented 10 months ago

CI says "no"

evgeni commented 10 months ago 
6 failed, 195 passed

okay, not that bad.

ekohl commented 10 months ago

At least this part fails: https://github.com/theforeman/obal/blob/3625419b8656e048a76f7ef8653b86be59ebee3f/obal/data/roles/fetch_sources/tasks/main.yml#L20-L24

I think that causes most if not all failures.

ekohl commented 10 months ago

Packaging wise we can depend on ansible-collection-ansible-posix but I'm not sure how to deal with pip based installations.

evgeni commented 10 months ago

This escalated not as much as I have feared. What are we missing? :)

ekohl commented 10 months ago

And copy works the same here? I don't know it well enough to say but I trust you

evgeni commented 10 months ago

It doesn't sync, but it does recursively copy, which should be sufficient for our usecase.

And the usage should be covered by tests, so…

ekohl commented 10 months ago

Thanks! I've reordered the commits and changed the commit messages, but no actual code changes. I believe this is ready to go, but can't approve my own PR.