Create pki_dir structure only if deploy

theforeman / puppet-certs

Puppet module for dealing with SSL certs across other modules used in Katello

GNU General Public License v3.0

5 stars 39 forks source link

Create pki_dir structure only if deploy #417

Closed ehelms closed 9 months ago

ehelms commented 1 year ago

Contains / requires -- https://github.com/theforeman/puppet-certs/pull/416

ehelms commented 1 year ago

@ekohl could you review?

ekohl commented 1 year ago

It took me a while to get to this, but I think the design could be slightly different. The biggest issue that I see is that every concrete class (qpid, puppet, foreman, etc) can deploy. In that case $certs::deploy may be false while $certs::foreman::deploy may be true.

I've opened https://github.com/theforeman/puppet-certs/pull/436 but I'm not 100% sure it is correct either.