theforeman / puppet-certs

Puppet module for dealing with SSL certs across other modules used in Katello
GNU General Public License v3.0
5 stars 39 forks source link

Mark compatible with puppet-extlib 7.x #437

Closed ekohl closed 1 year ago

ekohl commented 1 year ago

Argh, looks like https://github.com/theforeman/puppet-certs/pull/412 was merged but shouldn't have. The failures are Puppet 8 (or rather, Ruby 3.2) related:

  Info: Loading facts
  Info: Loading facts
  Info: Loading facts
  Info: Loading facts
  Notice: Compiled catalog for centos8-64-puppet8.example.com in environment production in 0.16 seconds
  Info: Using environment 'production'
  Info: Applying configuration version '1699372796'
  Notice: /Stage[main]/Certs::Install/Package[katello-certs-tools]/ensure: created
  Notice: /Stage[main]/Certs::Config/File[/root/ssl-build]/ensure: created
  Notice: /Stage[main]/Certs::Config/File[/etc/pki/katello]/ensure: created
  Notice: /Stage[main]/Certs::Config/File[/etc/pki/katello/certs]/ensure: created
  Notice: /Stage[main]/Certs::Config/File[/etc/pki/katello/private]/ensure: created
  Notice: /Stage[main]/Certs::Ca/File[/root/ssl-build/katello-default-ca.pwd]/ensure: defined content as '{sha256}b81ccc10c65d78df8372839958c951d3dfec3ab9d4dc11670065afc05224a69d'
  Error: /Stage[main]/Certs::Ca/Ca[katello-default-ca]: Could not evaluate: undefined method `exists?' for File:Class
  Error: /Stage[main]/Certs::Ca/Ca[katello-server-ca]: Could not evaluate: undefined method `exists?' for File:Class
  Notice: /Stage[main]/Certs::Ca/File[/root/ssl-build/KATELLO-TRUSTED-SSL-CERT]: Dependency Ca[katello-server-ca] has failures: true
  Warning: /Stage[main]/Certs::Ca/File[/root/ssl-build/KATELLO-TRUSTED-SSL-CERT]: Skipping because of failed dependencies
  Error: /Stage[main]/Certs::Ca/File[/etc/pki/katello/certs/katello-default-ca.crt]: Could not evaluate: Could not retrieve information from environment production source(s) file:///root/ssl-build/katello-default-ca.crt
  Error: /Stage[main]/Certs::Ca/File[/etc/pki/katello/certs/katello-server-ca.crt]: Could not evaluate: Could not retrieve information from environment production source(s) file:///root/ssl-build/katello-server-ca.crt
  Info: Class[Certs::Ca]: Unscheduling all events on Class[Certs::Ca]
  Info: Class[Certs]: Unscheduling all events on Class[Certs]
  Notice: /Stage[main]/Certs::Apache/Cert[centos8-64-puppet8.example.com-apache]: Dependency Ca[katello-default-ca] has failures: true
  Warning: /Stage[main]/Certs::Apache/Cert[centos8-64-puppet8.example.com-apache]: Skipping because of failed dependencies
  Warning: /Stage[main]/Certs::Apache/Certs::Keypair[centos8-64-puppet8.example.com-apache]/Private_key[/etc/pki/katello/private/katello-apache.key]: Skipping because of failed dependencies
  Warning: /Stage[main]/Certs::Apache/Certs::Keypair[centos8-64-puppet8.example.com-apache]/File[/etc/pki/katello/private/katello-apache.key]: Skipping because of failed dependencies
  Warning: /Stage[main]/Certs::Apache/Certs::Keypair[centos8-64-puppet8.example.com-apache]/File[/etc/pki/katello/certs/katello-apache.crt]: Skipping because of failed dependencies
  Info: Stage[main]: Unscheduling all events on Stage[main]
  Notice: Applied catalog in 4.96 seconds
ekohl commented 1 year ago

I'll merge this now and deal with Puppet 8 later.

ekohl commented 1 year ago

https://github.com/theforeman/puppet-certs/pull/438 is aimed at dealing with Puppet 8.