search

theforeman / puppet-dns

Installs and manages an ISC BIND DNS server with zones
Apache License 2.0
18 stars 70 forks source link

Remove dnssec-enable option for EL >= 9 #218

Closed ikonia closed 2 years ago

ikonia commented 2 years ago

validated against EL (Redhat / CentOS / Rocky) 7 - 8 - 9 functions correctly. Basic test against Fedora 35, which also works

Adds check of EL version greater than 7 and sets dnssec_enable parameter to undef if greater to allow the removal of the parameter from options.conf, which is a deprecated parameter in EL8 and later. This removes any warning in 9.15 and any breakage in 9.18 or later. Any version EL 7 or earlier includes the parameter allowing the user to set it on and off depending on if they want to use it, but the parameter is included as a valid parameter

ikonia commented 2 years ago

excellent feedback, happy to make the changes, I got the warning on my CentOS 8 bind host though, so I will go back and double check the version on that.

ikonia commented 2 years ago

do I need to look at the rspec test suites on this as while the module works fine on EL9 (which is where the test suite is failing) I'm not sure if these tests are known to fail, or if I should dig into them and look to update them. If they are expected passes I can look into updating them

ekohl commented 2 years ago

Yes, the failures are caused by your change.

ikonia commented 2 years ago

thank you, I'll look at the tests now.

ikonia commented 2 years ago

tests updated, thanks for the help