theforeman / puppet-dns

Installs and manages an ISC BIND DNS server with zones
Apache License 2.0
18 stars 70 forks source link

Remove legacy fact usage #225

Closed smortex closed 1 year ago

smortex commented 1 year ago

We can now run puppet without legacy facts:

puppet config set include_legacy_facts false

When doing so, the module fail to get the default value for $dns::zone::soa. Fix it by using the networking.fqdn fact.

While here, adjust a few more legacy facts.

ekohl commented 1 year ago

I'll consider this as a bugfix to 6426a394af5afebe7fe0c0c0f2b834198c75a52b.