search

theforeman / puppet-foreman

Puppet module for Foreman
GNU General Public License v3.0
104 stars 269 forks source link

Add Puppet 8 support #1126

Closed bastelfreak closed 10 months ago

bastelfreak commented 1 year ago

also contains https://github.com/theforeman/puppet-foreman/pull/1125

ekohl commented 10 months ago

I did notice there were deprecation warnings about the ERB template: https://github.com/theforeman/puppet-foreman/blob/93dbe6a07be0ba74d579df1a72515f0fd62e6fc4/templates/settings.yaml.erb#L2 This needs to use keyword arguments now (and is repeated in multiple files).

bastelfreak commented 10 months ago

@ekohl rebased on #1125

ekohl commented 10 months ago

I think https://github.com/theforeman/puppet-foreman/pull/1139 should be complete. I've opted to drop the deprecated non-namespaced functions instead of trying to fix them.