search

theforeman / puppet-foreman

Puppet module for Foreman
GNU General Public License v3.0
104 stars 269 forks source link

Service 'foreman' is started unconditionally #993

Open pkranenburg opened 3 years ago

pkranenburg commented 3 years ago

The current standard foreman configuration uses systemd socket activation to start the foreman/rails service on-demand, i.e. when a connection arrives on the 'unix:/run/foreman.sock' socket.

However, this puppet module unconditionally ensures a running systemd 'foreman.service'. This seems a redundant operation and kind of defeats the 'on-demand' part of the configuration.

ekohl commented 3 years ago

This was done in order to ensure it really starts. Also it can help with slow setups where you want to run the Foreman Proxy registration on the same host. I think a parameter can make sense if you want to, but the default should be running.