search

theforeman / puppet-foreman_proxy

Puppet module for Foreman Smart Proxy
GNU General Public License v3.0
43 stars 130 forks source link

Hardcoded amd64 packages in tftp class #346

Open GregSutcliffe opened 7 years ago

GregSutcliffe commented 7 years ago

I've just been playing with setting up a RaspberryPi based Foreman appliance, and hit a minor snag. In the TFTP class we hardcode the amd64 versions of the EFI Grub packages - this doesn't exist for ARM boards. There is an equivalent ARM package though.

What's the best solution here? Parameterise the EFI packages? Or maybe just add an $manage_efi flag and surround the whole EFI block with it?

GregSutcliffe commented 7 years ago

Opps, forgot the link to the tftp class - https://github.com/theforeman/puppet-foreman_proxy/blob/master/manifests/tftp.pp#L103

mmoll commented 7 years ago

AFAICT, the whole EFI implementation of all parts is amd64 only at the moment, but PRs welcome. :)

ekohl commented 7 years ago

https://github.com/theforeman/puppet-foreman_proxy/pull/347 does a bit in preparing for this by making the package names a variable.

ekohl commented 7 years ago

Right now I don't know which packages we should install on other arches

GregSutcliffe commented 7 years ago

https://packages.debian.org/search?suite=stable&section=all&arch=any&searchon=names&keywords=grub-efi is a list for debian at least. I think the issue is knowing which is right at any time. The architectire fact may not be reliable, eg, for picking between grub-efi-arm-bin and grub-efi-arm64-bin ...

ekohl commented 7 years ago

I like the foreman-bootloaders package because packaging is a much better place to solve architecture.

GregSutcliffe commented 7 years ago

Agreed, although then it has to exist for all the OSs we want to support. Which in my case is Arch ... ;)

EDIT: nvm, I see your netboot class handles this gracefully, +1