theforeman / puppet-katello

Puppet module for setting Katello specific configuration. Also includes provider for manipulating with Katello resources.
GNU General Public License v3.0
14 stars 48 forks source link

Fixes #35005: Drop setting Pulp client certificate settings #450

Closed ehelms closed 2 years ago

ehelms commented 2 years ago

These settings were introduced with Pulp 2 and carried over to Pulp 3 before we introduced client authentication support in smart_proxy_pulp. The support for using Foreman client certificates to talk to Pulp 3 was introduced in Foreman 3.0. This is now safe to drop.

ehelms commented 2 years ago

Current acceptance failures are due to nightly being broken, and this change can fix builds. So this is a bit of a chicken-n-egg problem. I ran these tests locally against the Koji staging repositories and given that was green -- choosing to merge.