search

theforeman / puppet-katello

Puppet module for setting Katello specific configuration. Also includes provider for manipulating with Katello resources.
GNU General Public License v3.0
14 stars 48 forks source link

Use Java 17 for Candlepin 4.3+ support #462

Closed lfu closed 1 year ago

ehelms commented 1 year ago

Couple of questions:

  1. Can Candlepin 4.3.1 use Java 11 or is it Java 17 only?
  2. Can the current version of Candlepin use Java 17?
  3. Is Candlepin 4.3.1 available in nightly repositories? If not, when is it planned to be available?

The reason I ask these questions is to help us ensure we take changes in the correct order so as not to break.

chris1984 commented 1 year ago

Couple of questions:

  1. Can Candlepin 4.3.1 use Java 11 or is it Java 17 only?
  2. Can the current version of Candlepin use Java 17?
  3. Is Candlepin 4.3.1 available in nightly repositories? If not, when is it planned to be available?

The reason I ask these questions is to help us ensure we take changes in the correct order so as not to break.

@ehelms here are the answers to your questions

  1. It can only use Java 17
  2. (from candlepin team) Maybe, but possibly not. If it does, it's not by any explicit intention on our part. We had to do some minor changes here and there to target Java17; but maybe the Java11 files will work? 4.3+ is where we officially support Java 17
  3. It is not yet, we are ready to tag it in.
ehelms commented 1 year ago

We'll have a period where things might be broken, but that's OK. The recommended order I see for us is:

  1. Update Candlepin in the repository
  2. Re-test this change here for the acceptance tests against our stage repositories
  3. Merge if green
lfu commented 1 year ago

Candlepin 4.3.1 has been tagged to nightly. Some of the tests failed here.

ekohl commented 1 year ago

It now fails on Puppet 6 since concat dropped Puppet 6 (or rather, Ruby 2.5) support and we use the latest version.

Something to deal with tomorrow.