allow changing http and https port

theforeman / puppet-pulp

Puppet module for setting up Pulp 2 as part of Katello installation

GNU General Public License v3.0

16 stars 66 forks source link

allow changing http and https port #326

Closed maxadamo closed 6 years ago

maxadamo commented 6 years ago

could you please allow to change http/https ports? see pull request: #325

Please Note: 2 tests out of 3 were successful, but - unless I'm overlooking - I don't think that the 3rd test has anything to do with my change. To me, it seems that your Travis test is a bit spoiled :-) May I suggest you to use PDK?

ekohl commented 6 years ago

The acceptance test is failing because of a regression. https://github.com/pulp/pulp/commit/81741bcc737867b31d7617c46b407c6280130528 has been merged but needs to be released.

I haven't had time yet to look at PDK. We already use the same gems that PDK would pull in so it hasn't really been a priority. https://github.com/theforeman/foreman-installer-modulesync has served us well enough but we're open to patches.

maxadamo commented 6 years ago

thanks for the explanation :+1: