search

theforeman / puppet-pulp

Puppet module for setting up Pulp 2 as part of Katello installation
GNU General Public License v3.0
16 stars 66 forks source link

Add support for different CA certificates for apache and pulp #381

Closed laugmanuel closed 4 years ago

laugmanuel commented 4 years ago

This PR allows the configuration of a different CA cert for the Apache Vhost and introduces the new parameter https_ca_cert.

It's a follow up to: https://github.com/theforeman/puppet-pulp/pull/277

ekohl commented 4 years ago

I'll let the tests continue before merging but otherwise it looks good to merge. I've been known to forget checking back so feel free to ping if it looks like that's the case.

laugmanuel commented 4 years ago

Tests are green - I think we are ready for merge if there are no other thoughts @ekohl

ekohl commented 4 years ago

Thanks!

evgeni commented 4 years ago

It seems this broke Katello? https://ci.centos.org/job/foreman-katello-nightly-test/653/console

systemd[1]: Starting The Apache HTTP Server...
httpd[22387]: AH00526: Syntax error on line 62 of /etc/httpd/conf.d/05-pulp-https.conf:
httpd[22387]: SSLCACertificateFile: file '/etc/pki/pulp/ca.crt' does not exist or is empty
systemd[1]: httpd.service: main process exited, code=exited, status=1/FAILURE
timogoebel commented 4 years ago

@evgeni: @laugmanuel is on PTO today.

evgeni commented 4 years ago

@timogoebel then I guess @ekohl has to jump in ;)

laugmanuel commented 4 years ago

@evgeni this change did indeed break Katello when a custom ca_cert is specified. I did implement a fix and it is currently running tests. I will open a PR as soon as the local tests are green. Sorry for the trouble!

laugmanuel commented 4 years ago

For reference https://github.com/theforeman/puppet-pulp/pull/382