Improve validation of ldap parameters

theforeman / puppet-pulp

Puppet module for setting up Pulp 2 as part of Katello installation

GNU General Public License v3.0

16 stars 66 forks source link

Improve validation of ldap parameters #403

Closed alexjfisher closed 4 years ago

alexjfisher commented 4 years ago

Make sure that none of the ldap parameters are undef if any of them have been set.

With this pattern, (using NotUndef), we avoid repeating the data types already specified in the parameter list.

alexjfisher commented 4 years ago

This PR obviously isn't that important and is more an example that anything else. (How to implement conditional parameter validation was discussed on slack this morning, and the benefits of using NotUndef came up)