theforeman / puppet-pulpcore

Puppet module for setting up Pulp 3 as part of Katello installation
GNU General Public License v3.0
2 stars 28 forks source link

Fixes #33446 - Allow configuring Pulpcore worker timeout #230

Closed wbclark closed 3 years ago

wbclark commented 3 years ago

@ekohl @evgeni this is now updated with all feedback from this and the other PR... thanks!

wbclark commented 3 years ago

force pushing to trigger CI

wbclark commented 3 years ago

@ekohl thank you for the feedback, I updated with the requested changes.

While the tests passed for me locally, for some reason CI has not run on my recent pushes. Any idea why that is?

ekohl commented 3 years ago

When I opened issues I saw:

This scheduled workflow is disabled because there hasn't been activity in this repository for at least 60 days.

That's kind of weird. I guess they optimize the cronjobs on idle repos (which probably makes sense) but for us it's also the PR testing. I've enabled it now, but I'll take it up with GH.

wbclark commented 3 years ago

@ekohl thanks! any other feedback on this PR or do you think we are good to go?