theforeman / puppet-pulpcore

Puppet module for setting up Pulp 3 as part of Katello installation
GNU General Public License v3.0
2 stars 28 forks source link

Fixes #33766 - Support Pulpcore 3.15 #238

Closed ekohl closed 3 years ago

ekohl commented 3 years ago

Looks like RQ is broken on EL7 with 3.15 but EL8 does pass. Perhaps some SCL issue.

ehelms commented 3 years ago

You could go either way that this broken rq depending on how we think about exposing the command line tool. The tests use rq directly to inspect the state of the workers and that command does not exist outside the SCL context (e.g. https://github.com/theforeman/puppet-pulpcore/blob/master/spec/acceptance/enable_new_tasking_system_spec.rb#L65).

So we either update packaging to make an SCL aware rq or just update our tests to enable the SCL context on EL7. Or we stop testing RQ on EL7 knowing it's gone in 3.16.

ekohl commented 3 years ago

Or we stop testing RQ on EL7 knowing it's gone in 3.16.

I'm leaning to the latter. We can even take the version into account here.

evgeni commented 3 years ago

The RQ issue is simple to fix: https://github.com/theforeman/puppet-pulpcore/pull/240

ekohl commented 3 years ago

This is now green. With the notes in README I would consider this a backwards compatible enhancement.