search

theforeman / puppet-pulpcore

Puppet module for setting up Pulp 3 as part of Katello installation
GNU General Public License v3.0
2 stars 28 forks source link

Pin Puppet in CI #279

Closed ekohl closed 1 year ago

ekohl commented 1 year ago

Puppet 8.0.0 was released with incorrect Ruby compatibility metadata, which confuses bundler. This pins to more specific versions.

In gha-puppet this was already done, but this module has a modified beaker pipeline (to run multiple Pulpcore versions) so doesn't benefit from it.

ekohl commented 1 year ago

So https://github.com/puppetlabs/puppetlabs-postgresql/pull/1425 is the next thing to chase ...

evgeni commented 1 year ago

And the next is https://github.com/puppetlabs/puppetlabs-apache/blob/28b2d0f8f0af3a7ff984d55dab55eb05f527351f/manifests/mod.pp#L58

So many rabbits, so many holes

evgeni commented 1 year ago

https://github.com/puppetlabs/puppetlabs-apache/pull/2408

evgeni commented 1 year ago

Huh, why is it installing Puppet 7.21, especially also on Puppet 6 acceptance branches?!

evgeni commented 1 year ago

Ooh, it's the puppet that is running "outside" to parse things and launch beaker

evgeni commented 1 year ago

the tests run now at least

ekohl commented 1 year ago

So Pulp 3.17 is just broken: ImportError: /usr/lib64/python3.8/site-packages/_solv.so: undefined symbol: repo_add_deb, version SOLV_1.0

And Puppet 6 is busted because of concat.

evgeni commented 1 year ago

Yeah. Shall we merge as-is as it's an improvement? :)

evgeni commented 1 year ago

Nothing is using 3.17 And 3.16 was last used with 3.2 https://github.com/theforeman/forklift/blob/master/vagrant/config/versions.yaml

ekohl commented 1 year ago

Yes, and then revive https://github.com/theforeman/puppet-pulpcore/pull/277