search

theforeman / puppet-pulpcore

Puppet module for setting up Pulp 3 as part of Katello installation
GNU General Public License v3.0
2 stars 28 forks source link

Relax max_requests #295

Closed dralley closed 1 year ago

dralley commented 1 year ago

The root cause of the memory leak has been established and resolved, so these aggressive values are no longer necessary

ekohl commented 1 year ago

The root cause of the memory leak has been established and resolved, so these aggressive values are no longer necessary

Out of interest: can you share a link?

dralley commented 1 year ago

@ekohl https://github.com/pulp/pulpcore/pull/4090

ekohl commented 1 year ago

Thanks. How one line can make such a big difference. That looks very recent so I'd like to see it propagate through packaging. It also needs updated tests to reflect the new numbers.

dralley commented 1 year ago

I believe the tests are testing changing those values rather than the current values, so they don't need to be changed. Unless you mean something else.

dralley commented 1 year ago

Oh, there's tests that weren't added in the previous PR that I missed.

dralley commented 1 year ago

@ekohl Pushed

ekohl commented 1 year ago

https://ci.theforeman.org/job/pulpcore-3.22-rpm-pipeline/ is still blocked (there was some issue in CentOS CI) and I'd like to wait for that to pass.