search

theforeman / puppet-pulpcore

Puppet module for setting up Pulp 3 as part of Katello installation
GNU General Public License v3.0
2 stars 28 forks source link

Fixes #37062 - Rename pulpcore::telemetry to pulpcore::analytics #326

Closed wbclark closed 7 months ago

wbclark commented 8 months ago

Pulp changed the setting name to ANALYTICS. The original name TELEMETRY is deprecated and could be removed in the future. Using pulp's preferred name will also remove the deprecation warning that appears in logs.

evgeni commented 8 months ago

Which Pulpcore release is the first to support the new name? 3.39?

wbclark commented 8 months ago

Which Pulpcore release is the first to support the new name? 3.39?

It was first introduced as TELEMETRY in 3.21 and renamed to ANALYTICS already in 3.22

evgeni commented 8 months ago

Splendid, then it is a breaking change because we change params, but it doesn't influence the supported Pulpcore versions.

wbclark commented 7 months ago

Re-running the one test that failed, as the failure appeared transient.

ekohl commented 7 months ago

It was first introduced as TELEMETRY in 3.21 and renamed to ANALYTICS already in 3.22

So we accidentally sent telemetry in 3.22, while we promised we didn't. That's not good.

ehelms commented 7 months ago

It was first introduced as TELEMETRY in 3.21 and renamed to ANALYTICS already in 3.22

So we accidentally sent telemetry in 3.22, while we promised we didn't. That's not good.

It was deprecated and a new naming scheme introduced alongside it. The TELEMETRY setting exists still in the main branch (https://github.com/pulp/pulpcore/blob/main/pulpcore/app/util.py#L320-L322).