theforeman / puppet-pulpcore

Puppet module for setting up Pulp 3 as part of Katello installation
GNU General Public License v3.0
2 stars 28 forks source link

reason for including apache in service.pp #332

Open wiad opened 6 months ago

wiad commented 6 months ago

In service.pp there is include apache - what is the reason behind this?

This creates a duplication issue if you wish to manage apache separately.

ekohl commented 6 months ago

It's a good question. https://github.com/theforeman/puppet-pulpcore/commit/04b9f5f4fbcaafd87c6ea056b9b499197739c7c4 doesn't really describe why. I think it can be safely dropped and rely on the (conditional) include inside pulpcore::apache.