Add ability to configure auth backends and classes

theforeman / puppet-pulpcore

Puppet module for setting up Pulp 3 as part of Katello installation

GNU General Public License v3.0

2 stars 28 forks source link

Add ability to configure auth backends and classes #346

Closed Scnaeg closed 1 month ago

Scnaeg commented 2 months ago

It would be nice to have some tests for this.

I've added some tests. Unfortunately bundler has conflicting requirements on the RHEL 8 system I have available so I couldn't actually run the tests and verify the tests.

Scnaeg commented 1 month ago

Thank you very much for the review and I'm so sorry for the leftovers. Definitely not my day...

Odilhao commented 1 month ago

The tests for 3.39, 3.49 and nightly failed after this merge, not sure if it's related.

https://community.theforeman.org/t/pulpcore-nightly-rpm-pipeline-395-failed/39058

evgeni commented 1 month ago

Well, CI was broken due to a syntax error: https://github.com/theforeman/puppet-pulpcore/pull/349, but GitHub still decided it's a good idea to auto-merge this, even if the required check didn't pass :see_no_evil:

I think this should also fix pulpcore RPM CI

ekohl commented 1 month ago

This isn't the first time auto-merge ignores a required check. At this point I really don't trust GH's auto-merge anymore.

evgeni commented 1 month ago

Yeah :cry:

https://ci.theforeman.org/job/pulpcore-nightly-rpm-pipeline/ is green at least again