theforeman / puppet-pulpcore

Puppet module for setting up Pulp 3 as part of Katello installation
GNU General Public License v3.0
2 stars 28 forks source link

Update puppet_metadata to ~> 4.0 and voxpupuli-acceptance to ~> 3.0 #347

Closed archanaserver closed 3 months ago

ekohl commented 4 months ago

Looks like an update that starts to require PostgreSQL 13 was done and we don't set that up on EL8 (EL9 defaults to PG 13):

  Notice: /Stage[main]/Pulpcore::Database/Pulpcore::Admin[migrate --noinput]/Exec[pulpcore-manager migrate --noinput]/returns: django.db.utils.NotSupportedError: PostgreSQL 12 or later is required (found 10.23).

So that isn't related to this PR, but something we should address.

archanaserver commented 3 months ago

Looks like an update that starts to require PostgreSQL 13 was done and we don't set that up on EL8 (EL9 defaults to PG 13): Notice: /Stage[main]/Pulpcore::Database/Pulpcore::Admin[migrate --noinput]/Exec[pulpcore-manager migrate --noinput]/returns: django.db.utils.NotSupportedError: PostgreSQL 12 or later is required (found 10.23). So that isn't related to this PR, but something we should address.

For the new version of PostgreSQL 13, how we can do that? Do we have to define new variable based on OS release or how you preferred to do this @ekohl ?

ekohl commented 3 months ago

As discussed elsewhere: https://github.com/theforeman/puppet-pulpcore/commit/c16ddb8acd3c3b7209c122b4e5807cb0e22dafb3 used a dash in RedHat-8.yaml but according to https://github.com/voxpupuli/voxpupuli-acceptance?tab=readme-ov-file#hiera it needs to be a file in the subdirectory (so a slash).

archanaserver commented 3 months ago

@ekohl it is passing all the tests now. thanks!