Add option to allow unauthenticated access to metrics, and for generic additions to auth

theforeman / puppet-puppet

Puppet module for Puppet client and server

GNU General Public License v3.0

88 stars 228 forks source link

Add option to allow unauthenticated access to metrics, and for generic additions to auth #904

Open fraenki opened 11 months ago

fraenki commented 11 months ago

NOTE: This is a resubmission of #849, rebased against current master branch to resolve conflicts. Fixes #850. Credits to @sshipway.

This minor change allows generic control of the auth.conf file, and permitting unauthenticated retrieval of metrics (as is required by our monitoring system)

2 new parameters to server class
Usage comments added
Spec tests added and run successfully

teluq-pbrideau commented 3 months ago

I also would like to see this move forward, I need the auth_extra parameter

sshipway commented 3 months ago

Yes, please lets get this merged, it is a simple and backwards-compatible change that will really help with flexibility.

teluq-pbrideau commented 1 month ago

@fraenki Any chances you could rebase with master? I’d like to use your change with the new 20.0.0 release. @ekohl Can I do something to help to move this forward?