Add support for PuppetDB API v4

theforeman / puppetdb_foreman

PuppetDB proxy in Foreman

http://theforeman.org

GNU General Public License v3.0

32 stars 23 forks source link

Closed avgerin0s closed 7 years ago

avgerin0s commented 7 years ago

Fix finding nodes by using certname over name (v3, v4)
Support non-string facts
Add :puppetdb_api_version option instead of parsing the URI to guess the version

timogoebel commented 7 years ago

@eavgerinos: Thanks.

[test] - this kicks our ci pipeline

timogoebel commented 7 years ago

[test]

timogoebel commented 7 years ago

@eavgerinos: Any news on this? Do you need help somewhere?

avgerin0s commented 7 years ago

@timogoebel Sorry, I was busy with other issues, I'll implement the requested changes asap.

timogoebel commented 7 years ago

@eavgerinos : Thanks. Could you check out if https://github.com/timogoebel/puppetdb_foreman/commit/7c86b403fabe6f14389978b4b7c2332dc942aef6 is a suitable solution for you? If you like it, just squash it in and we're ready to merge once tests pass.

timogoebel commented 7 years ago

[test]

timogoebel commented 7 years ago

Closing due to inactivity.