search

theforeman / puppetdb_foreman

PuppetDB proxy in Foreman
http://theforeman.org
GNU General Public License v3.0
32 stars 23 forks source link

Add ability to view puppet classes and types for individual hosts/nodes #55

Closed leewaa closed 6 years ago

leewaa commented 6 years ago

Fixes #53.

leewaa commented 6 years ago

@timogoebel thanks. I made the adjustments as per your requests. Show be good to go now !

leewaa commented 6 years ago

@timogoebel The breadcrumb bar will work once https://github.com/theforeman/foreman/pull/5614 is in.

leewaa commented 6 years ago

I will change the breadcrumb bar so that it works for nodes, not hosts :D :D

leewaa commented 6 years ago

@timogoebel I ended up leaving the breadcrumb switcher out for now, it needs some work to be able to work with non active-record objects, and some more thought needs to be put into the current API also. Foreman does a lot of work in this respect and I don't want add all that dependancy to this Plugin.

For now the breadcrumb items are defined manually as the default does not work out of the box. I could pack it away into a helper, but I like the more explicit approach in the view.

timogoebel commented 6 years ago

@leewaa: Can you please check out the failing test?

AccessPermissionsTest.test_0742_route puppetdb_foreman/nodes/show should have a permission that grants access

I believe defining a permission for the route in engine.rb should be enough.

timogoebel commented 6 years ago

[test puppetdb_foreman]

timogoebel commented 6 years ago

Thanks, @leewaa.