Use the certname rather than the hostname to delete

theforeman / puppetdb_foreman

PuppetDB proxy in Foreman

http://theforeman.org

GNU General Public License v3.0

32 stars 23 forks source link

Use the certname rather than the hostname to delete #63

Closed ekohl closed 1 year ago

ekohl commented 5 years ago

The deactivate node requires the certname. In Foreman we track this separately.

https://puppet.com/docs/puppetdb/6.4/api/command/v1/commands.html#deactivate-node-version-3

Note I haven't tested this.

timogoebel commented 1 year ago

@ekohl: Is this still relevant? If it is, do you mind rebasing the PR?

ekohl commented 1 year ago

I think this is still relevant for users who use UUIDs for certificate names, but I'm not sure how many of those we do have and if it still even works.

timogoebel commented 1 year ago

rubocop complains, otherwise: looks good. :)

timogoebel commented 1 year ago

Merci.