theforeman / puppetdb_foreman

PuppetDB proxy in Foreman
http://theforeman.org
GNU General Public License v3.0
32 stars 23 forks source link

Make migrations compatible with settings category removal #80

Closed stejskalleos closed 1 year ago

stejskalleos commented 1 year ago

See:

https://github.com/theforeman/foreman/pull/9524 https://github.com/theforeman/foreman/pull/9524#issuecomment-1404661119

stejskalleos commented 1 year ago

Migrations fixed, but now it's failing on webpack:

Can't find our webpack executable at /home/jenkins/workspace/puppetdb_foreman-pull-request/label/fast/ruby/2.7/foreman/node_modules/.bin/webpack - have you run `npm install`?
/home/jenkins/workspace/puppetdb_foreman-pull-request/label/fast/ruby/2.7/foreman/lib/tasks/webpack_compile.rake:19:in `block (2 levels) in <top (required)>'

Why is webpack involved?

ekohl commented 1 year ago

That's a good question, since there is no package.json it shouldn't have any webpack resources. It's probably fallout from https://github.com/theforeman/jenkins-jobs/commit/ebfdda28aaab0c218b9bceef1fd56575c5dfd425 where $database was previously undefined, but now rake jenkins:integration is run unconditionally. And jenkins:integration pulls in webpack:compile: https://github.com/theforeman/foreman/blob/4381a7bb7fadf5c3c11f0976343b1b025edf5039/lib/tasks/jenkins.rake#L6

ekohl commented 1 year ago

I opened https://github.com/theforeman/jenkins-jobs/pull/337 which I think should fix it.

ekohl commented 1 year ago

[test puppetdb_foreman]

ekohl commented 1 year ago

[test puppetdb_foreman]