theforeman / safemode

A library for safe evaluation of Ruby code based on ParseTree/RubyParser and Ruby2Ruby. Provides Rails ActionView template handlers for ERB and Haml.
http://www.artweb-design.de
MIT License
68 stars 20 forks source link

Move to Ruby 2.7+ #45

Closed ekohl closed 11 months ago

ekohl commented 1 year ago

Ruby 2.5 and 2.6 are unsupported and providing Ruby 3 compatibility is easier with Ruby 2.7 as the lower bound.

It should be noted that from testing it appears Ruby 3 support is broken. Should the upper bound be lower to < 3 for now?

adamruzicka commented 1 year ago

Should the upper bound be lower to < 3 for now?

I'd say yes.

ekohl commented 1 year ago

The diffs would be smaller if https://github.com/svenfuchs/safemode/pull/43 was merged, but I've updated it now.

adamruzicka commented 11 months ago

Could we also drop lib/rubyparser_bug.rb while we're at it?

ekohl commented 11 months ago

Done

adamruzicka commented 11 months ago

Thank you @ekohl !