theforeman / smart_proxy_abrt

Automatic Bug Reporting Tool plugin for Foreman's smart-proxy
GNU General Public License v3.0
0 stars 5 forks source link

Refs #9089 - port to refactored SSL verification #3

Closed mmilata closed 9 years ago

mmilata commented 9 years ago

Introduced to smart-proxy in 0207401d84ddb5e4396157a38ad32a675f0e3e8f.

mmilata commented 9 years ago

@lzap does this look alright to you? I didn't test it yet because my foreman-nightly machine fell apart ...

mmilata commented 9 years ago

I've tested it now and it seems to work fine.

lzap commented 9 years ago

:+1:

lzap commented 9 years ago

One additional comment - this basically introduces incompatibility. Your plugin now requires Foreman 1.8. I recommend to bump the mayor version according to our plugin versioning guidelines.

mmilata commented 9 years ago

Right - I'll bump the major version when releasing new gem.