smart_proxy_abrt should accept for enabled setting values like http, https

theforeman / smart_proxy_abrt

Automatic Bug Reporting Tool plugin for Foreman's smart-proxy

GNU General Public License v3.0

0 stars 5 forks source link

Closed cristifalcas closed 9 years ago

cristifalcas commented 9 years ago

Based on the discussion from https://github.com/theforeman/puppet-foreman_proxy/issues/191#issuecomment-140715736, it seems that the setting "enabled" should accept also as values "http" and "https".

mmilata commented 9 years ago

Do you think it's sufficient to reverse the check in https://github.com/theforeman/smart_proxy_abrt/blob/master/bin/smart-proxy-abrt-send#L27 to if AbrtProxy::Plugin.settings.enabled == false?

I haven't been working on this plugin for some time but this seems like an easy fix.

ekohl commented 9 years ago

That could work or maybe you can reuse the enabled logic from the smartproxy code?

mmilata commented 9 years ago

Does 79734ba look good? If so I can release new version of the plugin.