search

theforeman / smart_proxy_monitoring

Smart proxy plugin for monitoring system integration
GNU General Public License v3.0
7 stars 10 forks source link

Send downtime parameters via the body #30

Closed ekohl closed 1 year ago

ekohl commented 1 year ago

This avoids needing to URL encode the parameters and simplifies the code. This removes the need for URI.encode, which is removed in Ruby 3.

ekohl commented 1 year ago

@dgoetz the API guide (https://icinga.com/docs/icinga-2/latest/doc/12-icinga2-api/#schedule-downtime & https://icinga.com/docs/icinga-2/latest/doc/12-icinga2-api/#remove-downtime) suggested this was valid. I haven't tested it yet, but can confirm this makes sense?

ekohl commented 1 year ago

@dgoetz could you take a look?

dgoetz commented 1 year ago

Sorry, did not see this. Looks good on a first look, but I want to test it before merging with a real setup. I hope to find some time in the near future as one of my todos is an update of the training material which always includes testing all the labs where I can simply at such tests to my list.