search

theforeman / smart_proxy_monitoring

Smart proxy plugin for monitoring system integration
GNU General Public License v3.0
7 stars 10 forks source link

Upgrade to Ruby 3.1 #32

Closed archanaserver closed 1 year ago

archanaserver commented 1 year ago

Adding Ruby v3 supports.

Requires:

archanaserver commented 1 year ago

Given it's a functionality change I'd suggest to include #30 as a separate commit. I think the easiest way is to use hub. Use hub pr checkout 30 to check out the branch and then git rebase $BRANCH.

@ekohl Done! But wouldn't that be good to separate both the changes in diff PRs- like one is all about ruby 3 upgrdae and other one is about the functionality change. This way anyone can validate those changes and able to easily track it too. So if you can prefer to merge https://github.com/theforeman/smart_proxy_monitoring/pull/30 first before switching to this PR?

dgoetz commented 1 year ago

Merged #30

archanaserver commented 1 year ago

@ekohl I have rebased my changes on top of the #30.

ehelms commented 1 year ago

This appears to still include a second commit that appears to be a modification of a previously merged change. I'd recommend dropping that commit and re-pushing.

ekohl commented 1 year ago

I rebased & merged because I thought it would drop the commit, but looks like there was also a change in it so there is now 8b924eb45dd22256dea672708da0d749aa4792f7.