search

theforeman / theforeman-rel-eng

Release engineering scripts
0 stars 15 forks source link

Reduce settings needed for every release #330

Closed ekohl closed 7 months ago

ekohl commented 8 months ago

This explicitly requires FULLVERSION to be set when needed. This allows them to be dropped from client and pulpcore settings.

It also automatically sets it for FOREMAN_VERSION, not in every single settings file.

ekohl commented 8 months ago

Untested for now, so a draft.

@ehelms is FULLVERSION needed to be set for Candlepin, or can it be dropped like Pulpcore?

ehelms commented 8 months ago

Untested for now, so a draft.

@ehelms is FULLVERSION needed to be set for Candlepin, or can it be dropped like Pulpcore?

Let's assume dropable for now.

ehelms commented 8 months ago

@ekohl I'd love for you to revisit this so I can finish off the Copr work and align our use of scripts in CI and locally.

ekohl commented 7 months ago

@evgeni mind giving this a sanity check?