search

theforeman / theforeman-rel-eng

Release engineering scripts
0 stars 15 forks source link

Allow branching katello without foreman_version #338

Closed wbclark closed 7 months ago

wbclark commented 7 months ago

This was previously added as a requirement because of the Katello release procedure, but it's not used anywhere in the Katello branching procedure currently, and the too-strict conditional is breaking the command that generates the Katello branching procedure.

ekohl commented 7 months ago

I'll need to take a look. Katello branching still relies on Foreman branching. Many critical steps (like packaging) are now in the Foreman procedure.

On mobile now, so hard to check but do we call these sychronization steps out? For release we do say not to announce GA before Foreman, but perhaps these should be called out more

wbclark commented 7 months ago

I'll need to take a look. Katello branching still relies on Foreman branching. Many critical steps (like packaging) are now in the Foreman procedure.

On mobile now, so hard to check but do we call these sychronization steps out? For release we do say not to announce GA before Foreman, but perhaps these should be called out more

I looked for content in the katello branching template that used the foreman_branching variable, or for obvious places where it would benefit from that addition, and couldn't find any.

The key issue is that context[:foreman_version] is not set in the command corresponding to branch in the procedures hash (but is set for the release command by comparison), so the unless conditional was blocking @qcjames53 and I from rendering the template.

I don't mind setting context[:foreman_version] in the branch command either to fix this if you prefer that route, I just didn't see a need for it today based on the current template contents.