search

theforeman / theforeman-rel-eng

Release engineering scripts
0 stars 15 forks source link

Use branching date as target_date in branching procedures #340

Closed wbclark closed 7 months ago

wbclark commented 7 months ago

All procedures currently accept a single target_date. For branching procedures in particular, if the branching date is used as the target_date, this generates correct dates in the section headings but an incorrect date in the command invocation to generate the release procedure. This commit fixes the inconsistency by assuming the branch date is the target_date in branching, and adding four weeks to that date to get the date for GA.

wbclark commented 7 months ago

@ekohl so, using the current cycle as an example, the target_date used to generate the release procedure should be February 20th, even though GA is planned for March 19th, because the target_date is referring to RC1 and not to GA?

Is the RC1 release procedure the only one that is generated in this way?

ekohl commented 7 months ago

That is exactly what is happening, so it's all working as intended. Targeted branching date is equal to targeted RC1 date.

wbclark commented 7 months ago

Cool, thanks for the explanation.