search

theforeman / theforeman-rel-eng

Release engineering scripts
0 stars 15 forks source link

Verify VERSION inside the tarball is correct #383

Closed ekohl closed 1 month ago

ekohl commented 1 month ago

Previously I always did this by hand, but it's rather trivial to verify automatically.

The manual inspection using file-roller is kept in, but arguably there's less need for that now. In the past I've made sure versions were correct (mostly applies to the installer), but the point of this check was always to verify Jenkins built correct tarballs.

evgeni commented 1 month ago

You offended the ShellCop, but otherwise LGTM