search

theforeman / theforeman-rubocop

Foreman RuboCop basic rules
2 stars 7 forks source link

Upgrade to RuboCop 1.5 #3

Closed ezr-ondrej closed 3 years ago

ezr-ondrej commented 3 years ago

Upgrade to RuboCop 1.5 and disable some of new rules for lenient style.

I'll release it as 0.1.0.pre

lzap commented 3 years ago

Have you tested this does not break Foreman core?

Rubocop rules are always heated topic, can we disable mergning our own PRs for this repo? We should require also a review. @tbrisker :-)

ezr-ondrej commented 3 years ago

I wanted to try it out on github and for that, I needed to release... this will break foreman that's why it's just prerelease. I've just disabled the obvious ones that we won't want to implement in core, but left untouched the ones I thing would be usefull...

ezr-ondrej commented 3 years ago

but noted, I'll not merge myself nextime :+1: