search

theforeman / theforeman-rubocop

Foreman RuboCop basic rules
2 stars 7 forks source link

Upgrade RuboCop version to 1.60.0 #8

Closed archanaserver closed 1 month ago

archanaserver commented 10 months ago

This is part of Rubocop standerdization, link for the reference: https://community.theforeman.org/t/standardizing-rubocop-with-theforeman-rubocop/37239

ekohl commented 10 months ago

As discussed, please create some PR to a user of this gem to see how it performs.

ekohl commented 10 months ago

I started with a PR to REX to fix some cops: https://github.com/theforeman/foreman_remote_execution/pull/848

Then I'd like you to submit more PRs with the actual updates. One example is https://github.com/ekohl/foreman_remote_execution/commit/e07dfde3555bb16fd013f09171e81f1c693949b5.

archanaserver commented 10 months ago

I started with a PR to REX to fix some cops: theforeman/foreman_remote_execution#848

Then I'd like you to submit more PRs with the actual updates. One example is ekohl/foreman_remote_execution@e07dfde.

Thanks @ekohl, I've started with the foreman_maintain: https://github.com/theforeman/foreman_maintain/pull/789

ekohl commented 9 months ago

Another thing to note: foreman itself only uses theforeman-rubocop 0.0.6 today. It would also be good to see what would happen if you update that.

archanaserver commented 2 months ago

@ekohl are the following PRs ready for review and merging, including this one?

https://github.com/theforeman/theforeman-rubocop/pull/11 https://github.com/theforeman/theforeman-rubocop/pull/9