theforumhelpers / theforumhelpers.github.io

The site for the Scratch group "The Forum Helpers"
https://theforumhelpers.github.io/
MIT License
26 stars 16 forks source link

Documentation: Credits page needs to be updated #248

Closed leahcimto closed 3 years ago

leahcimto commented 3 years ago

What does this affect? Credits page

Changes/Additions The order of users needs to be changed.

gosoccerboy5 should be moved after leahcimto, BarelySmooth should be added after NilsTheBest, FunctionalMetatable should be after BarelySmooth, Shluffy should be after FunctionalMetatable, and TheColaber should be added after Nambaseking01.

The grid should look like this:

Screen Shot 2021-06-16 at 5 42 59 PM

The contributors variable should be updated to the following:

var contributors = ["Accio1", "leahcimto", "gosoccerboy5", "NilsTheBest", "BarelySmooth", "FunctionalMetatable", "Shluffy", "Nambaseking01", "TheColaber", "shefwerld", "ShadowOfTheFuture", "bremea", "awesome-llama", "CodeGuy92", "jeffalo", "MTM828", "The64thCucumber"]

I have a branch for this and a PR should be up soon.

Steve0Greatness commented 3 years ago

Why?

gosoccerboy5 commented 3 years ago

I don't think I deserve to be the 3rd

leahcimto commented 3 years ago

Why?

@Steve0Greatness This is how the credits page is set up. Users are placed in order of contributions they make, and users with no commits are placed after them in alphabetical order.

Accio1 commented 3 years ago

Closed in #249