Update Forum Helpers JSON Files

leahcimto commented 2 years ago

Resolves:

Resolves #302

Changes:

Moves managers.json and curators.json to originalManagers.json and originalCurators.json.
Updates managers.json and curators.json with new studio curators list.
managers.json and curators.json now have a new JSON key that states if the user is in the original studio.
Adds new bios to managers.json and curators.json that were requested on the TFH-Bios Scratch account

Local Tests:

Tested locally at https://leahcimto.github.io/theforumhelpers.github.io/forumhelpers/. (The latest commit adding new users is not included in this)

fun fact: the dot is very useful

leahcimto commented 2 years ago

If anyone could help look through the JSON files and let me know of any errors, that would be much appreciated.

leahcimto commented 2 years ago

I'm starting to wonder if this is not an issue with the json, after looking it over it looks fine.

FunctionalMetatable commented 2 years ago

I'm starting to wonder if this is not an issue with the json, after looking it over it looks fine.

Incorrect URL for managers.json.

leahcimto commented 2 years ago

@FunctionalMetatable

It's in the folder though

CST1229 commented 2 years ago

You are trying to get https://leahcimto.github.io/forumhelpers/managers.json, but it should be https://leahcimto.github.io/theforumhelpers.github.io/forumhelpers/managers.json.

FunctionalMetatable commented 2 years ago

yeah

leahcimto commented 2 years ago

@CST1229 @FunctionalMetatable Thank you! I have tested it now, and it looks good! I need to add two more users though and remove one, and then I will mark this as ready for review!

leahcimto commented 2 years ago

Okay, I added the two new users. The user banananology was in the past studio, but on a different account. I still marked them as an original user.

leahcimto commented 2 years ago

This is now ready for review.

CST1229 commented 2 years ago

I'm assuming the users are correct. Small request: just to save on space when this ends up being hosted on a server for TFH Dashboard (hopefully soon). Could, the "original" key be replaced with something shorter, such as "og" or something, and true/false replaced with t/f.

Also minify the JSON file.

leahcimto commented 2 years ago

@Accio1 Done

leahcimto commented 2 years ago

@Accio1 bump

leahcimto commented 2 years ago

Added a new curator and fixed an error.

Accio1 commented 2 years ago

I'm going to block this for now pending the next TFH dashboard release to make sure the database gets filled with the correct information. The next TFH dashboard release should be coming soon, so stay tuned.

CST1229 commented 2 years ago

I'm assuming the users are correct. Small request: just to save on space when this ends up being hosted on a server for TFH Dashboard (hopefully soon). Could, the "original" key be replaced with something shorter, such as "og" or something, and true/false replaced with t/f.

@Accio1 I think true and false could be replaced with 1 and 0 since they're shorter than strings and they're even equivalent in some languages. Also minify the JSON on the server (not here).

leahcimto commented 2 years ago

two users should be promoted

leahcimto commented 2 years ago

New curators need to be added. I won’t have access to my computer until tomorrow so I hope to do it then.

leahcimto commented 2 years ago

Bio for user VioletCalico: Hello! I’m VioletCalico, an active forumer who mostly posts on Questions About Scratch and Suggestions! I also try to post on Bugs and Glitches and New Scratcher often.

leahcimto commented 2 years ago

New users added.

leahcimto commented 2 years ago

Needs bios for ~~AIGamesDeveloper~~ (done) and mbrick2.

Mbrick2 commented 2 years ago

What about my Bio?

leahcimto commented 2 years ago

@Mbrick2 please be patient, it's coming. I should have time to do it this afternoon.

leahcimto commented 2 years ago

promote wangat add Nambaseking01

leahcimto commented 2 years ago

add ssb20 new bio Hi, I’m Super_Scratch_Bros20, but you can call me SSB20. I’m a forumer who wants to help however I can. I can be found on Questions about Scratch, Suggestions, and sometimes Things I’m Reading and Playing. If you have any questions, feel free to contact me. Scratch On!

leahcimto commented 2 years ago

Add bio for @Shluffy (dogsmakemehappy) #314 : "Hi! I am dogsmakemehappy, also known as Shluffy or ShluffyMonster on other sites. I am currently inactive and I work on modding minecraft Java Edition"

leahcimto commented 2 years ago

add new users: sharkode 46685332 jackson49 18502842 portalpower 28289107 historical_supa 71825463 ScolderCreations 68889501 Adzboy 84839537 minikiwigeek2 27872815 DinoMaster20 44985322

leahcimto commented 2 years ago

@leahcimto remember to do this

theforumhelpers / theforumhelpers.github.io