search

theforumhelpers / theforumhelpers.github.io

The site for the Scratch group "The Forum Helpers"
https://theforumhelpers.github.io/
MIT License
26 stars 16 forks source link

placeholder text #339

Closed leahcimto closed 2 years ago

leahcimto commented 2 years ago

Resolves:

Partially fixes #299

Changes:

Adds placeholder text

Not sure if this is what you all meant by placeholder text, or you wanted to hide the whole sentence and put placeholder text there and then show the whole sentence?

Local Tests:

None

leahcimto commented 2 years ago

@Accio1 I was working on having it disappear, see a1cb746. I was having some trouble with that, does anyone have suggestions or see things that I'm doing wrong?

Accio1 commented 2 years ago

@Accio1 I was working on having it disappear, see a1cb746. I was having some trouble with that, does anyone have suggestions or see things that I'm doing wrong?

I went ahead and pushed a commit to fix it. You were using .style.display = "hidden"; but it should be .style.display = "none";

I also condensed it down to one for loop instead of doing it separately for the curators and managers one. If you're good with these changes @leahcimto then we can go ahead and merge.

leahcimto commented 2 years ago

Also to comply with the timeline in #325 do you mind disabling GH Pages in the QuickReply repository and then tomorrow archive it (or now for that matter)?

Accio1 commented 2 years ago

Also to comply with the timeline in #325 do you mind disabling GH Pages in the QuickReply repository and then tomorrow archive it (or now for that matter)?

Thanks for the reminder. I've disabled GitHub pages and I'll archive it tomorrow.