search

theforumhelpers / theforumhelpers.github.io

The site for the Scratch group "The Forum Helpers"
https://theforumhelpers.github.io/
MIT License
26 stars 16 forks source link

Update the "I've been accepted! Now what?" section #347

Closed penguinmoose closed 2 years ago

penguinmoose commented 2 years ago

Resolves:

Resolves #343

Changes:

In the application instructions, it says to leave a bio on the TFH-Bios account, not using the dashboard. This will update the text so it says to leave a bio using the dashboard instead, with a link to the dashboard (as well as a link to the TFH list and -Accio-'s and leahcimto's Scratch profiles).

Local Tests:

I tested the changed file on an online HTML editor and it looked okay (I tried using Github Desktop, but for some reason, it did not update).

penguinmoose commented 2 years ago

@leahcimto Sure. I agree.

penguinmoose commented 2 years ago

@Accio1 @leahcimto Does this look good? If so, can you approve it?

leahcimto commented 2 years ago

@Accio1 @leahcimto Does this look good? If so, can you approve it?

@penguinmoose I don't see your commit...

penguinmoose commented 2 years ago

@leahcimto hmm let me check

penguinmoose commented 2 years ago

@leahcimto yeah, I might have forgot. I’ll do it tonight.

penguinmoose commented 2 years ago

@Accio1 @leahcimto I made the commit. Can you take a look at it and approve it if it looks good? I already tested it on an online HTML editor.

penguinmoose commented 2 years ago

@Accio1, can you approve this PR?

penguinmoose commented 2 years ago

@Accio1 ? Can you approve?

penguinmoose commented 2 years ago

@Accio1, can you approve?

penguinmoose commented 2 years ago

@BarelySmooth Someone needs to approve it. Can you if you like it?

leahcimto commented 2 years ago

@BarelySmooth Someone needs to approve it. Can you if you like it?

@penguinmoose This doesn't need any more approval, it just needs to be merged by Accio1. Wait a week or so before pinging them again.

BarelySmooth commented 2 years ago

@BarelySmooth Someone needs to approve it. Can you if you like it?

Me approving wouldn’t make a difference. Only Accio and leahcimto can approve PRs (with the green checkmark), since they have write access.

On 03-Aug-2022, at 9:20 PM, Helloworldbyeworld @.***> wrote:

@BarelySmooth https://github.com/BarelySmooth Someone needs to approve it. Can you if you like it?

— Reply to this email directly, view it on GitHub https://github.com/theforumhelpers/theforumhelpers.github.io/pull/347#issuecomment-1204254586, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT6ZNPAIMRU35FWVW4NR563VXKS4FANCNFSM54T4IIVA. You are receiving this because you were mentioned.

penguinmoose commented 2 years ago

Oh, I see. Both Leahcimto and Accio need to approve it?

BarelySmooth commented 2 years ago

Oh, I see. Both Leahcimto and Accio need to approve it?

This repo doesn't have a minimum number of required approvals to merge a PR. Anyone with repository edit access can merge it.

(this is getting kinda offtopic, you should probably open a discussion if you'd like to know more)

penguinmoose commented 2 years ago

@BarelySmooth Got it. I'll just wait a week or two.

penguinmoose commented 2 years ago

Okay, pinging them (one day early)!

@Accio1, can you approve and merge? This PR is still not merged.

Accio1 commented 2 years ago

@Accio1, can you approve this PR?

@Accio1 ? Can you approve?

@Accio1, can you approve?

Okay, pinging them (one day early)!

@Accio1, can you approve and merge? This PR is still not merged.

@penguinmoose In the future, please do not do this. Requesting my review once is sufficient. I have been inactive because I have been recovering from having my wisdom teeth out and spending time with family. Pinging me four times for review in the span of less than two weeks is unnecessary and impolite.