Open tobias-graf-p opened 1 year ago
Please also note that there is a fork of this action at https://github.com/Stelzi79/action-minver with some nice improvements. Would be great if you could merge these into this main project of this action.
And also some dependencies should be updated.
Considering that the last commit of the original author was in 2019 I figured that this repo is abandoned and started to publish my fork. I am looking into fixing this issue there (https://github.com/Stelzi79/action-minver/issues/17)
I recommend taking minver as a <PackageReference />
in your csproj instead, and configuring it through msbuild props.
@thefringeninja Thank you for your suggestion. I also thought about this option before I started to use your Github action. But in my case the situation is as follows:
My C# project is built as part of building the Docker image. Because I need the version already for steps which are executed before the docker image build/push step (using docker/build-push-action@v3
), e.g. for creating the docker image metadata using docker/metadata-action@v4
(and also for other purposes), (I think) I have to use MinVer as a dotnet tool early in the workflow. Or do you see another option here?
(Of course I could use another Github action out there to calculate the version somewhere in the workflow, but since I do indeed use the MinVer tool in my C# project, I think it would be great to use the same tool in the workflow ...)
@thefringeninja Again thank you for your suggestion. Kindly wanted to ask again whether you see another option for my requirements (see my above post)?
Hi
Is there any chance that this action will be updated in the near future? We use it in our workflows and (since a few weeks) notice the following issues:
@actions/core
package should be updated tov1.10.0
or greater to get the updated saveState and setOutput functions (see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/)Node.js
should be updated tov16
inaction.yml
.