Closed minkimcello closed 4 years ago
@minkimcello I think the workflow should be,
release
action checks for deprecated: true flag and runs npm deprecate
@cowboyd is this what you had in mind?
@taras
Using deprecate flag on package.json
:
Using deprecate action separate from release action:
The only downside to this is when we want to rename packages. But I don't know how we would approach that.
I'm not a big fan of making separate actions. Ultimately, I want everything living in 1 utility... maybe we have different actions but I'm not sure yet.
@cowboyd what do you think?
Resolved with #58, #59, and #60.
Context
From this pull request on bigtest, I was removing unused packages from the monorepo and the discussion of deprecating those packages was initiated.
But first to address some of the comments from that pull request:
@taras:
should we add a mechanism to release action to somehow deprecate packages?
@cowboyd:
what about adding a deprecated flag to the package.json
Solution
Create a new action to deprecate packages.
Approach
synchronize-with-npm
torelease
and create the new action asdeprecate
on push
tomaster
branch.npm deprecate
.