thefrontside / actions

Collection of GitHub Actions created by Frontside
5 stars 1 forks source link

Remove quotations from package names for deprecating #59

Closed minkimcello closed 4 years ago

minkimcello commented 4 years ago

Motivation

The latest deprecation feature has a small bug which can be seen here. We were passing in the names of the packages directly from the package.json property which is formatted with quotations but the npm deprecate command does not like that.

Approach

Inside synchronize-with-npm the package names are being filtered so that any quotation marks at the beginning and end of the string is removed.