thefrontside / bigtest

Ensure your React/Vue/Ember/anything app works perfectly across browsers.
https://frontside.com/bigtest
99 stars 14 forks source link

Return Task to prevent unhandled promise warning #1026

Closed jnicklas closed 2 years ago

jnicklas commented 2 years ago

This makes runTest on the runner return a task, rather than a promise.

Since we call runTest without actually observing the result thereof, if we convert the task into a promise, we end up in a situation where we have created a promise but not attached any error handlers to it. This causes a warning to be printed to the console. By returning the task directly and not converting it to a promise, we avoid this problem and also increase flexibility in how the runner is used.

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 7345735c7068a9dafc5a63cf5ed994b9aef7b242

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR