Upload node 16 binary (attempt #2)

[minkimcello]

Motivation

25 did not turn out the way we had hoped

Approach (Updated ✨)

• The tests were passing in #25 but we weren't actually using the node versions in the matrix (via volta). So I fixed that in the test workflow and ~I'm also running the upload workflow but without any of the prechecks and without creating a release nor uploading the binaries to see if it actually builds using node-pre-gyp~.
  • See successful build of 10, 12, 14, 16 here
  • Upload workflow was reverted with 16 added so that it runs on push on main branches again after confirming it works in this PR
• Bumped neon, neon-build, and neon-cli to latest in order to build in node 16.
• Updated CHANGELOG and bumped package to 1.0.5 to trigger upload and release.

TODOs

• ⚠️ The windows tests in Github Actions will sometimes fail which requires me to re-run the test workflow until it passes.
  • The windows tests from commit a04d4f5 ran successfully
  • And the windows tests for the last commit is failing even though the only changes are to a separate workflow, the package version of ctrlc-windows, and the CHANGELOG.

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 6fbfa24e4eaa5778917216b56fcde2dab77b3a54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[minkimcello]

@cowboyd @jbolda Do we really need node 15? Seems others have had issues building in node 15 too.

[jbolda]

I think it is pretty common to not support the odd number versions once the even number version is released.

[minkimcello]

@jbolda I can't figure out how windows node 16 tests passed before and now it can't. 🤦 All that's changed is the changelog, reverting the upload workflow to run on push instead of pull, and bumping the ctrlc-windows package version.

[minkimcello]

😠

[jbolda]

@jbolda I can't figure out how windows node 16 tests passed before and now it can't. 🤦 All that's changed is the changelog, reverting the upload workflow to run on push instead of pull, and bumping the ctrlc-windows package version.

I think we weren't running tests on node 16 before. It didn't seem to work on 0.5 on my end, but it's possible the 0.8 might. We can try it locally on my computer if you think that might help.

[minkimcello]

@jbolda I can't figure out how windows node 16 tests passed before and now it can't. 🤦 All that's changed is the changelog, reverting the upload workflow to run on push instead of pull, and bumping the ctrlc-windows package version.

I think we weren't running tests on node 16 before. It didn't seem to work on 0.5 on my end, but it's possible the 0.8 might. We can try it locally on my computer if you think that might help.

The tests run successfully on node 16 (or I guess I should say it builds successfully because it's the build step that's failing) if the version of ctrcl-windows in package.json is <=1.04. Is there a part in the build process where it pulls from npm by any chance?

[minkimcello]

Closing in favour of #26. Node 16 with neon is a no go.