search

thefrontside / ctrlc-windows

Send a CTRL-C event to a Windows console application
9 stars 2 forks source link

migrate to @mapbox/node-pre-gyp #32

Closed zburke closed 3 years ago

zburke commented 3 years ago

Motivation

Issue #31: node-pre-gyp has moved to @mapbox/node-pre-gyp. The current ^0.16.0 dependency generates an install warning under npm:

npm WARN deprecated node-pre-gyp@0.16.0: Please upgrade 
to @mapbox/node-pre-gyp: the non-scoped node-pre-gyp 
package is deprecated and only the @mapbox scoped package 
will recieve updates in the future

Approach

Update to a supported version and run the tests (they pass). Breaking changes in @mapbox/node-pre-gyp were minimal and appear to be on code surfaces that are not touched here so this seems low-risk.

changeset-bot[bot] commented 3 years ago

🦋 Changeset detected

Latest commit: 32987307be8b9700e44f756ad6d5e3e68ec2a4ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------- | ----- | | ctrlc-windows | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

cowboyd commented 3 years ago

@zburke Thanks so much for this contribution! The world is such a better place when we all take the time to submit pull requests upstream for annoying things.