Closed taras closed 7 years ago
Yeah, I think we should actually move the full implementation to vendor
. We'd have to write it in ES5, but the whole code path is basically < 100 lines so it seems easier...
Ok, will do. Thank you!
Taras Mankovski @tarasm
On Thu, Sep 1, 2016 at 11:59 AM +0530, "Robert Jackson" notifications@github.com wrote:
Yeah, I think we should actually move the full implementation to vendor. We'd have to write it in ES5, but the whole code path is basically < 100 lines so it seems easier...
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
This looks good to me.
@cowboyd this should be good to go
@rwjblue Glimmer supporting helper is more complex than previous. I had to copy and paste some babel.js transpiled code. Can you please take a look and let me know if this looks alright?
I think the plain ES5 looks better (https://github.com/thefrontside/ember-let/pull/13#discussion_r77357218), lets use that instead of babel output.
@rwjblue I agree. I forgot how to ES5 :)
@Robdel12 @cowboyd this is ready go
let
registration to-private/keyword
ember-let
is not available when vendor is being calledCloses: #11