thefrontside / ember-let

Create variable bindings inside your handlebars templates
MIT License
52 stars 16 forks source link

initialize let helper via vendor file #13

Closed taras closed 7 years ago

taras commented 7 years ago

Closes: #11

rwjblue commented 7 years ago

Yeah, I think we should actually move the full implementation to vendor. We'd have to write it in ES5, but the whole code path is basically < 100 lines so it seems easier...

taras commented 7 years ago

Ok, will do. Thank you!

Taras Mankovski @tarasm

On Thu, Sep 1, 2016 at 11:59 AM +0530, "Robert Jackson" notifications@github.com wrote:

Yeah, I think we should actually move the full implementation to vendor. We'd have to write it in ES5, but the whole code path is basically < 100 lines so it seems easier...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

mmun commented 7 years ago

This looks good to me.

taras commented 7 years ago

@cowboyd this should be good to go

taras commented 7 years ago

@rwjblue Glimmer supporting helper is more complex than previous. I had to copy and paste some babel.js transpiled code. Can you please take a look and let me know if this looks alright?

rwjblue commented 7 years ago

I think the plain ES5 looks better (https://github.com/thefrontside/ember-let/pull/13#discussion_r77357218), lets use that instead of babel output.

taras commented 7 years ago

@rwjblue I agree. I forgot how to ES5 :)

taras commented 7 years ago

@Robdel12 @cowboyd this is ready go