search

thefrontside / ember-let

Create variable bindings inside your handlebars templates
MIT License
52 stars 16 forks source link

Add baseDir to index.js to silence htmlbars caching deprecation warning #22

Closed cafreeman closed 8 years ago

cafreeman commented 8 years ago

Basically just stealing this fix from ember-cp-validations to fix the same deprecation.

Robdel12 commented 8 years ago

Tests go 💥

rwjblue commented 8 years ago

Tests are failing because the helpers being used in tests are mutating the array / hash (which is not allowed in 2.9+). They will need to be update/rewritten to .slice() the arrays and Ember.merge({}, hash) to avoid mutating.

cafreeman commented 8 years ago

Rebasing the changes from @taras

cafreeman commented 8 years ago

Good to go now! Thanks for the fix @taras and @rwjblue!

Robdel12 commented 8 years ago

Awesome work! :D